1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/conio/bitmap_con.c

    From Deuc¿@VERT to Git commit to main/sbbs/master on Tuesday, April 25, 2023 20:59:33
    https://gitlab.synchro.net/main/sbbs/-/commit/743b2ae00956dfaa52080a4b
    Modified Files:
    src/conio/bitmap_con.c
    Log Message:
    Move vstat copy inside vstatlock

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Friday, April 28, 2023 13:51:19
    https://gitlab.synchro.net/main/sbbs/-/commit/24cb0a05bcdf56d8925554e4
    Modified Files:
    src/conio/bitmap_con.c
    Log Message:
    Clean up blinker thread

    There was a lot of weird things going on to avoid locking vstatlock
    inside of screenlock. Simply this by copying needed vstat stuff
    while we hold the lock.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Friday, April 28, 2023 21:10:46
    https://gitlab.synchro.net/main/sbbs/-/commit/026c7d89b401a4da7196d631
    Modified Files:
    src/conio/bitmap_con.c
    Log Message:
    Extend cstatlock to cover vmem

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Wednesday, May 03, 2023 13:25:22
    https://gitlab.synchro.net/main/sbbs/-/commit/fe019abeb0c4104e1562d311
    Modified Files:
    src/conio/bitmap_con.c
    Log Message:
    Remove unused variables

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Friday, May 05, 2023 21:03:13
    https://gitlab.synchro.net/main/sbbs/-/commit/c625f2e6f764e4e80d2eab87
    Modified Files:
    src/conio/bitmap_con.c
    Log Message:
    Fix buffer overflow in bitmap movetext()

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Friday, May 05, 2023 21:16:28
    https://gitlab.synchro.net/main/sbbs/-/commit/18607b08946590f5a36a1959
    Modified Files:
    src/conio/bitmap_con.c
    Log Message:
    Fixx off-by-one in last commit.

    Stupid 1-based coordinates.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Friday, May 05, 2023 22:44:48
    https://gitlab.synchro.net/main/sbbs/-/commit/bbd16c32cf6e33a1d1cdb7bf
    Modified Files:
    src/conio/bitmap_con.c
    Log Message:
    Fix more buffer overflows.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Monday, June 05, 2023 15:03:29
    https://gitlab.synchro.net/main/sbbs/-/commit/7cdf96b094437ed39f49008d
    Modified Files:
    src/conio/bitmap_con.c
    Log Message:
    Fix GDI brakage in frameskipping.

    Win32GDI currently requires two rects to be available.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on ChromeOS)@VERT to Git commit to main/sbbs/master on Sunday, June 18, 2023 13:22:12
    https://gitlab.synchro.net/main/sbbs/-/commit/14da36cb0e3a333e162b9a26
    Modified Files:
    src/conio/bitmap_con.c
    Log Message:
    Fix GCC UBSan (SANITIZE=1 build) runtime error

    left shift of 255 by 24 places cannot be represented in type 'int'

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuce@VERT to Git commit to main/sbbs/master on Saturday, July 29, 2023 11:29:37
    https://gitlab.synchro.net/main/sbbs/-/commit/febaa22a9f29c18777b14b9a
    Modified Files:
    src/conio/bitmap_con.c
    Log Message:
    Fix non-integer scaling corruption when r2y is NULL

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Saturday, February 10, 2024 16:45:22
    https://gitlab.synchro.net/main/sbbs/-/commit/0e9e499fa00a31db0271fa73
    Modified Files:
    src/conio/bitmap_con.c
    Log Message:
    Resolve some MSVC warnings

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Saturday, February 24, 2024 07:07:39
    https://gitlab.synchro.net/main/sbbs/-/commit/92216995054bc941ffc88a68
    Modified Files:
    src/conio/bitmap_con.c
    Log Message:
    Don't imply the callbacks need to be protected by the mutex.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Friday, January 09, 2026 07:33:17
    https://gitlab.synchro.net/main/sbbs/-/commit/7b75eedac533e5ff97bd504e
    Modified Files:
    src/conio/bitmap_con.c
    Log Message:
    Fix have_blink calculation

    The old method was flawed because when we're cheating (most of the
    time), it wouldn't get set to true even when there's blinking text
    somewhere on the screen.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Wednesday, March 04, 2026 23:48:10
    https://gitlab.synchro.net/main/sbbs/-/commit/cd13711d07a94744ef301142
    Modified Files:
    src/conio/bitmap_con.c
    Log Message:
    Fix bug calculating snaps in height-controlled modes.

    There really aren't that many height-controlled modes, but an error
    in the number of scanlines made ST132X36_16_9 into one.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Saturday, March 14, 2026 18:14:10
    https://gitlab.synchro.net/main/sbbs/-/commit/090c08a33308e9832fa21e6f
    Modified Files:
    src/conio/bitmap_con.c
    Log Message:
    Fix chunk end calculation for split vmem update

    Previously, would write the same areas multiple times, potentially
    resulting in differrent CRCs.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Saturday, March 14, 2026 18:14:10
    https://gitlab.synchro.net/main/sbbs/-/commit/58ce9083d1d0352337d28c18
    Modified Files:
    src/conio/bitmap_con.c
    Log Message:
    Perform split updates with a single lock

    No need for a lock/unlock wrapper.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Saturday, March 14, 2026 18:14:10
    https://gitlab.synchro.net/main/sbbs/-/commit/5bffab544f4fb52d66e4cf4a
    Modified Files:
    src/conio/bitmap_con.c
    Log Message:
    Fix a handful of subtle bugs caught running the terminal test...

    1) bitmap_draw_from_vmem() had some math wrong, which could result
    in a frame or two of the screen being drawn split. This was visible
    as a flash of the status bar being in the middle of the screen.
    2) With the update to a rwlock, the force parameter to update_from_vmem()
    NEEDS to ensure a redraw is done for consistency. While eventual
    consisency is fine for most cases, getting the checksum of a region
    strictly requires the region is fully updated first.
    3) vstat was being written in two cases with the read lock held...
    one was when resetting the "changed" flag to false during an
    update, and the other was when adjusting the reveal bit in prestel
    mode.
    4) bitmap_movetext() and the corresponding bitmap_movetext_screen()
    almost certainly had a bug in them. They basically did the exact
    same thing, just one to the vmem and the other to the screen data.
    How they went about that however was wildly different. Rewrote
    most of these functions so they re-use calculations and don't
    both do hard-to-understand math.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Sunday, March 15, 2026 14:09:13
    https://gitlab.synchro.net/main/sbbs/-/commit/8dda8ba2f94dd1534aacf061
    Modified Files:
    src/conio/bitmap_con.c
    Log Message:
    Fix integer division in bitmap_setcustomcursor() cursor scaling

    The ratio variable is declared as double, but vstat.charheight/r performed integer division since both operands are int. This truncated the scaling
    ratio (e.g. 16/14 = 1 instead of 1.143), causing cursor start/end positions
    to not scale correctly when switching between font heights.

    Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Tuesday, March 17, 2026 00:41:05
    https://gitlab.synchro.net/main/sbbs/-/commit/e0b825c458da099f74f1fc6d
    Modified Files:
    src/conio/bitmap_con.c
    Log Message:
    Pre-compute Prestel double-height row states once per frame

    calc_charstate() was scanning all rows 0..ypos-1 for every cell to
    determine top/bottom double-height status, making full redraws
    O(rows^2 * cols). Pre-compute the row state array once in
    update_from_vmem() and pass it through the call chain. Callers from bitmap_setpixel/setpixels pass NULL to retain the existing per-cell
    scan (always single-cell, so the old path is fine).

    Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Tuesday, March 17, 2026 10:47:28
    https://gitlab.synchro.net/main/sbbs/-/commit/070cbc5c3dc94166d5f5a667
    Modified Files:
    src/conio/bitmap_con.c
    Log Message:
    Remove TODO comment... yes, we do.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Tuesday, March 17, 2026 11:59:17
    https://gitlab.synchro.net/main/sbbs/-/commit/14f279ca37de873b6fb75317
    Modified Files:
    src/conio/bitmap_con.c
    Log Message:
    Hold vstat_chlock when setting vmem->changed in blinker thread

    Every other write to vmem->changed holds vstat_chlock; this was the
    sole exception. The wrlock on vstatlock already prevented concurrent
    access in practice, but this makes the locking protocol consistent
    and is not in a hot path. (Coverity CID 644904)

    Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Saturday, March 21, 2026 10:14:19
    https://gitlab.synchro.net/main/sbbs/-/commit/c7ed5d30673a1a4c595ba916
    Modified Files:
    src/conio/bitmap_con.c
    Log Message:
    Add a dotted underline on the bottom cell row for OCS 8

    Makes hyperlinks more discoverable.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Saturday, March 21, 2026 17:58:42
    https://gitlab.synchro.net/main/sbbs/-/commit/d7f9da7d45ee2d342f2b7328
    Modified Files:
    src/conio/bitmap_con.c
    Log Message:
    Initialize hyperlink_id for initial window

    Reported at Kampfire.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net