1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/sbbsecho.c

    From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Sunday, September 17, 2023 23:27:45
    https://gitlab.synchro.net/main/sbbs/-/commit/f9b0dda5a1cac371a50f9f3f
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Add more detail (e.g. line number) to various "error opening" log msgs

    Some of the errors could be pretty vague since they looked the same and
    we were depending on the path/file attempted to be opened in the log msg
    to clue us into what exactly was being attempted. But some of these file
    paths are sysop-configurable, and they can put unexpected things in there
    that make it difficult to determine exactly what file was trying to be
    opened and for what purpose. This should help a little bit.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Monday, December 04, 2023 21:14:35
    https://gitlab.synchro.net/main/sbbs/-/commit/43fb687f2e138e183f841a42
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix issue when packing netmails for multiple different linked-nodes

    Introduced in commit 15b230af (9 months ago), the first linked-node config (including packet password!) for the first packed netmail message would be reused for subsequent packed netmail messages.

    Thank you to Wilfred van Velzen (2:280/464) for reporting this problem!

    Additional debug-level log message when using a packet password for a newly created packet.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Monday, December 04, 2023 22:57:40
    https://gitlab.synchro.net/main/sbbs/-/commit/28e435bdc2e909f38032afd4
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Combine the "new packet" and "password-protected" debug-log lines

    ... to de-clutter the log

    Also, don't log the packet passwords. Folks copy and post sbbsecho.log lines and that could seriously compromise the security of the Interwebs if those super-secret passwords were ever leaked!

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Friday, December 15, 2023 17:25:50
    https://gitlab.synchro.net/main/sbbs/-/commit/fc9d641054b36d9a84cc87da
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix typo in previous commit

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sunday, December 31, 2023 17:16:52
    https://gitlab.synchro.net/main/sbbs/-/commit/6e1118af6abf0c55ca608a29
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Don't use wildcard node packet password (if one exists)

    This also addresses the addresses with 65535 in them in the new debug-level
    log messages "New packet (type x) created for linked-node" .

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sunday, December 31, 2023 17:16:52
    https://gitlab.synchro.net/main/sbbs/-/commit/c2f663c30ab71c7493babab4
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Log message attributes in human-readable form (not just hexadecimal)

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sunday, January 07, 2024 20:47:22
    https://gitlab.synchro.net/main/sbbs/-/commit/623613492036f9806c225436
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Expand sole-LFs in message text (shouldn't normally be there)

    Expanded to CRLF or just CR (if strip LFs is enabled).

    It is possible for someone to stuff LF-terminated text in a message, so let's account for that possibility upon export to FTNs where LFs are supposed to be ignored.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Wednesday, February 07, 2024 10:47:17
    https://gitlab.synchro.net/main/sbbs/-/commit/20aecd3a4d979af82e3f509b
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix more warnings...

    It looks like we may need a set of PRI?TIME macros for printf()ing
    a time_t.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Saturday, March 16, 2024 20:11:36
    https://gitlab.synchro.net/main/sbbs/-/commit/9b28769f4b669763409f0435
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Bugfix: actually use the SMB netattr 'HOLD' attribute flag

    ... when exporting from SMB to .msg ("stored message") file

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Saturday, March 23, 2024 16:12:16
    https://gitlab.synchro.net/main/sbbs/-/commit/4c7a908f8ee55161faf3be71
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Insure buf is null-terminated in getzpt(), resoving CID 488308

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Saturday, March 23, 2024 17:13:28
    https://gitlab.synchro.net/main/sbbs/-/commit/5a2a73ae1b20ddf3563c23fe
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix typo in previous commit to this file

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Monday, September 09, 2024 18:29:23
    https://gitlab.synchro.net/main/sbbs/-/commit/0f0a8a1ae72c424509eaa72d
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Refactor the function: unpack_bundle()

    1. When a 0-length bundle file was encountered or an unpacking error occurred,
    any remaining bundles for the current search day-of-week (e.g. *.SU*) would
    be skipped/ignored. This bug (issue #764, regarding the 0-length file part),
    is fixed by not incrementing the day-of-week index in the main loop, but
    rather only incremeting the index when all bundles for the current
    day-of-week have been processed.
    2. The age calculation for 0-byte/length bundle files was incorrect, so all
    0-length bundle files would always be considered "less than 24-hours old"
    (and thus, never auto-deleted).
    This exacerbated the problem of issue #764 since it would persist until the
    0-length files were manually deleted. Fixed the file age calculation and
    now logging the date/timestamp of the 0-length file as well.
    3. Don't do the switch/case/sprintf dance when we're not re-running a glob()
    search.
    4. Replace the switch/case statement with an array of week day names/patterns. 5. Ignore (with a warning log message) any sub-directories of the inbound
    directory that happen to match the bundle file search pattern.
    6. Use better variable naming.
    7. Refer to files with a length of 0 as "0-length" instead of "0-byte" in log
    messages.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sunday, September 22, 2024 16:57:13
    https://gitlab.synchro.net/main/sbbs/-/commit/6177a1c02241acc45a1b0858
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix potential null pointer dereference

    strListReadFile() can return NULL upon error

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Friday, March 14, 2025 21:19:09
    https://gitlab.synchro.net/main/sbbs/-/commit/8010070c0bc86aaf8104a144
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Take the configured origin line chars into account when determining charset

    and if the message is UTF-8, encode the origin line as UTF-8 too.
    If the message is straight ASCII (e.g. the sub-board is configured as ASCII only), convert the configured origin line to ASCII, before appending.

    At this time, only ASCII and CP437 encodings of originlines are supported
    in Synchronet (imported and exported origin lines can contain UTF-8).

    This should address the issue raise by Sergey Dorofeev (2:5020/12000) in the FidoNet UTF-8 echo whereby messages exported from Synchronet systems (presumably using SBBSecho) could contain a mixture of CP437 and UTF-8 encodings (!) when the sysop had CP437 chars in their configured origin line.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Friday, March 14, 2025 21:19:09
    https://gitlab.synchro.net/main/sbbs/-/commit/ca0d64e4e73f352dbfcd4f1b
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Eliminate some unnecessary typecasts and parens

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Friday, March 14, 2025 21:21:49
    https://gitlab.synchro.net/main/sbbs/-/commit/f78d5395969b6a38a4db8adc
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Add typecast to elminate GCC warning

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Wednesday, December 24, 2025 19:50:40
    https://gitlab.synchro.net/main/sbbs/-/commit/241bd37f9feb34506c3b295d
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Better logging around area list file open failures

    This also fixes the empty "Title" key/valiue lines in the echostats.ini file.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Gamgee@VERT/PALANTIR to MRO on Tuesday, February 04, 2025 18:41:06
    poindexter FORTRAN wrote to Rob Swindell (on Windows 11) <=-

    This should automatically solve the "non-intuitive" configuration issue reported via DOVE-net by poindexter FORTRAN (REALITY).

    Thanks!

    Yep, and you're welcome for my answer too, which explained it, but you couldn't be bothered to acknowledge... :-\



    ... Post may contain information unsuitable for overly sensitive persons.
  • From Denn to Gamgee on Saturday, December 27, 2025 12:02:57
    Re: Re: src/sbbs3/sbbsecho.c
    By: Gamgee to MRO on Tue Feb 04 2025 06:41 pm

    MRO wrote to k9zw <=-
    Alas my system merged this in another echo... puzzling how at the
    moment... appreciate the reply!

    put your data files in their own sub directory for each msg network
    you have.

    That isn't necessary and certainly is not the default way.

    But it does keep the directories a little tidier.

    ... Remember how simple life was when there were only two sexes?
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Wednesday, February 18, 2026 17:30:14
    https://gitlab.synchro.net/main/sbbs/-/commit/9c4557e96766bb7e6b73edf4
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix a couple more new-GCC warnings

    using gcc (GCC) 15.2.1 20260209 "assignment discards const qualifier"

    reported by Accession

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Saturday, April 18, 2026 02:27:17
    https://gitlab.synchro.net/main/sbbs/-/commit/3422dabc7807f1fff56ebb9e
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix compile errors on GCC 15.2

    error: passing argument 2 of `getfmsg' from incompatible pointer type [-Wincompatible-pointer-types]

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Wednesday, May 06, 2026 19:41:53
    https://gitlab.synchro.net/main/sbbs/-/commit/326057fd5c56c0c77a5e0d34
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    sbbsecho: free pkt->filename on fopen failure in find_stray_packets (CID 530517)

    When the new outpkt_t cannot be opened for append, free(pkt) was called
    without first releasing the strdup'd pkt->filename, leaking the path
    for every stray packet whose append-open fails.

    Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Wednesday, May 06, 2026 19:41:53
    https://gitlab.synchro.net/main/sbbs/-/commit/9ef727bc25d13118b3ba5323
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    sbbsecho: cast away unchecked chmod/remove returns in alter_areas (CIDs 462777, 515046)

    Both calls in alter_areas() are best-effort: the chmod is a permission
    preserve before rename, and the remove is documented to be expected to
    fail when the file doesn't exist. Make the ignore-return intent explicit
    with (void) casts so Coverity stops flagging them as CHECKED_RETURN.

    Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net